Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-cmd/audit: don't error out if no license is detected by GitHub #7901

Merged
merged 1 commit into from
Jul 4, 2020
Merged

dev-cmd/audit: don't error out if no license is detected by GitHub #7901

merged 1 commit into from
Jul 4, 2020

Conversation

dawidd6
Copy link
Member

@dawidd6 dawidd6 commented Jul 4, 2020 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Should fix Homebrew/homebrew-core#57432 (comment) and any other cases where License is not recognized by GitHub.

@request-info request-info bot added the needs response Needs a response from the issue/PR author label Jul 4, 2020
@Homebrew Homebrew deleted a comment from request-info bot Jul 4, 2020
@dawidd6 dawidd6 removed the needs response Needs a response from the issue/PR author label Jul 4, 2020
@MikeMcQuaid
Copy link
Member

Makes sense to me, thanks @dawidd6!

@MikeMcQuaid MikeMcQuaid merged commit 988692c into Homebrew:master Jul 4, 2020
@dawidd6 dawidd6 deleted the noassertion-license branch July 4, 2020 19:00
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 26, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dawidd6 @MikeMcQuaid @BrewTestBot